Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mypy directives and type hinting for [Core, Builders, API] #1057

Merged
merged 27 commits into from
Jul 23, 2024
Merged

Mypy directives and type hinting for [Core, Builders, API] #1057

merged 27 commits into from
Jul 23, 2024

Conversation

tsmathis
Copy link
Collaborator

attempting to unpin pymatgen resulted in mypy errors during dependency upgrades when using pymatgen versions >=2024.6.10

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.83784% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.99%. Comparing base (f1928e2) to head (6f985f6).

Files Patch % Lines
emmet-core/emmet/core/xas.py 0.00% 4 Missing ⚠️
emmet-builders/emmet/builders/utils.py 76.92% 3 Missing ⚠️
emmet-core/emmet/core/elasticity.py 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
+ Coverage   89.83%   89.99%   +0.15%     
==========================================
  Files         143      143              
  Lines       13425    13428       +3     
==========================================
+ Hits        12061    12085      +24     
+ Misses       1364     1343      -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tsmathis added 16 commits July 22, 2024 09:45
@tsmathis tsmathis force-pushed the core-type-hinting branch from 303e2c9 to a6ec3f5 Compare July 22, 2024 16:48
@tsmathis tsmathis changed the title Mypy directives and type hinting for Core Mypy directives and type hinting for [Core, Builders, API] Jul 22, 2024
@tsmathis tsmathis added Core Any updates for Emmet-Core Builders Any updates for Emmet-Builders labels Jul 22, 2024
@tsmathis tsmathis force-pushed the core-type-hinting branch from 32a1511 to 6f985f6 Compare July 22, 2024 19:05
@tsmathis tsmathis marked this pull request as ready for review July 22, 2024 19:21
@tsmathis tsmathis requested a review from munrojm July 22, 2024 19:21
@tsmathis
Copy link
Collaborator Author

@munrojm, can I get a look over on this one? Some of mypy fixes did catch some typing errors within emmet (e.g., b77e622), but there's still a lot of sprinkling mypy ignore directives around

munrojm
munrojm reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@munrojm munrojm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsmathis tsmathis merged commit b92b2d5 into main Jul 23, 2024
10 checks passed
@tsmathis tsmathis deleted the core-type-hinting branch July 23, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munrojm munrojm munrojm left review comments

Assignees
No one assigned
Labels
Builders Any updates for Emmet-Builders Core Any updates for Emmet-Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsmathis @codecov-commenter @munrojm