Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default long description text for emmet-core #1013

Merged
merged 1 commit into from
May 13, 2024

Conversation

tsmathis
Copy link
Collaborator

Trying to pip install emmet-core in a container (Docker) context will throw the following error:

× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [7 lines of output]
    Traceback (most recent call last):
      File "<string>", line 2, in <module>
      File "<pip-setuptools-caller>", line 34, in <module>
      File "/tmp/pip-install-hxr58vdl/emmet-core_4bad4006d3d442a6ae60dc59dcf5ac78/setup.py", line 10, in <module>
        long_description=open("../README.md").read(),  # noqa: SIM115
                         ^^^^^^^^^^^^^^^^^^^^
    FileNotFoundError: [Errno 2] No such file or directory: '../README.md'
    [end of output]

PR adds some default text for the long_description field to allow container builds to succeed.

@tsmathis
Copy link
Collaborator Author

tests failing again due to #389 in pmg-analysis-diffusion. No new release over there yet.

@tsmathis tsmathis merged commit 2301701 into main May 13, 2024
4 of 10 checks passed
@tsmathis tsmathis deleted the emmet-core_setup_description_text branch May 13, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant