Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace monty which with shutil which #92

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Replace monty which with shutil which #92

merged 3 commits into from
Mar 22, 2022

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Mar 18, 2022

Summary

monty.os.path.which is deprecated and will be removed in v2023. Replaced with shutil.which.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #92 (0e2c967) into main (ce31ec0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   70.65%   70.65%           
=======================================
  Files          46       46           
  Lines        3973     3973           
  Branches      622      622           
=======================================
  Hits         2807     2807           
  Misses       1006     1006           
  Partials      160      160           
Impacted Files Coverage Δ
src/atomate2/vasp/schemas/calculation.py 83.85% <100.00%> (ø)
src/atomate2/vasp/files.py 92.85% <0.00%> (ø)

@utf
Copy link
Member

utf commented Mar 22, 2022

Thanks!

@utf utf merged commit e797fdd into materialsproject:main Mar 22, 2022
@Andrew-S-Rosen Andrew-S-Rosen deleted the rosen-which branch March 22, 2022 17:26
gpetretto pushed a commit to gpetretto/atomate2 that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants