Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial for blob storage with test #776

Merged
merged 16 commits into from
Jul 18, 2024
Merged

Tutorial for blob storage with test #776

merged 16 commits into from
Jul 18, 2024

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Mar 15, 2024

Tutorial for blob storage with test

  • Added tutorial for store_volumetric_data
  • Added a way for notebooks to be tested.

Additional dependencies introduced (if any)

nbmake to make testing possible.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.51%. Comparing base (29a5731) to head (c595647).
Report is 36 commits behind head on main.

Current head c595647 differs from pull request most recent head b567eb9

Please upload reports for the commit b567eb9 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
+ Coverage   74.94%   76.51%   +1.56%     
==========================================
  Files         136      114      -22     
  Lines       10513     8506    -2007     
  Branches     1643     1275     -368     
==========================================
- Hits         7879     6508    -1371     
+ Misses       2143     1612     -531     
+ Partials      491      386     -105     

see 41 files with indirect coverage changes

@janosh janosh added docs Improvements or additions to documentation testing Test all the things labels Mar 17, 2024
@jmmshn
Copy link
Contributor Author

jmmshn commented Mar 20, 2024

@utf let me know if this change looks OK, I can start writing the other tutorials.

Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the slow reply @jmmshn. this looks great to me! that said @utf might have more specific requirements for the docs that i'm unaware of?

either way, i think it's safe to proceed with this nbmake setup to allow testing the docs in CI

@JaGeo
Copy link
Member

JaGeo commented May 16, 2024

@jmmshn I am really excited about integrating such tutorials once this is merged. Especially for the phonon workflow, this is straightforward.

@utf
Copy link
Member

utf commented Jul 18, 2024

Thanks @jmmshn this looks great.

@utf utf enabled auto-merge (squash) July 18, 2024 15:14
@utf utf merged commit 42cae12 into materialsproject:main Jul 18, 2024
6 checks passed
@JaGeo
Copy link
Member

JaGeo commented Jul 19, 2024

@utf shouldn't this tutorial be somehow connected to the documentation? I am a bit confused where to put new tutorials. We would like to migrate our tutorial on the phonon workflows to atomate2.

BryantLi-BLI pushed a commit to BryantLi-BLI/atomate2 that referenced this pull request Jul 29, 2024
* tut test

* tut test

* tut test

* nbmake

* nbmake

* nbmake

* nbmake

* nbmake

* nbmake

* enums

* enums

* nbmake

---------

Co-authored-by: Alex Ganose <[email protected]>
hrushikesh-s pushed a commit to hrushikesh-s/atomate2 that referenced this pull request Nov 16, 2024
* tut test

* tut test

* tut test

* nbmake

* nbmake

* nbmake

* nbmake

* nbmake

* nbmake

* enums

* enums

* nbmake

---------

Co-authored-by: Alex Ganose <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation testing Test all the things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants