-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Atomate2 support in OpenMM #717
Conversation
Hi @orionarcher and @xperrylinn, this looks great. Thanks for contributing this back to atomate2. On first glance, the code looks very nice. I'll try and get some proper comments back to you in the next few days. |
Thanks @utf! Head's up that we are working to reorganize the code around the OpenFF Interchange object, which is a much closer analog to |
Ok, thanks for the heads up. I'll hold off reviewing for now. Let me know when you want me to take a look. |
Summary
This PR ports over functionality from atomate2-openmm developed by @xperrylinn and myself. It includes:
InputSets
usingpymatgen.io.openmm
Additional dependencies introduced
These are all necessary for the classical MD setup and execution workflow.
TODO (if any)
Checklist
Before a pull request can be merged, the following items must be checked:
The easiest way to handle this is to run the following in the correct sequence on
your local machine. Start with running
ruff
andruff format
on your new code. This willautomatically reformat your code to PEP8 conventions and fix many linting issues.
Run ruff on your code.
type check your code.
Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply run
pre-commit install
and a check will be run prior to allowing commits.Questions:
Best way to deal with new requirements?