-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lobster mp workflow #634
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
- Coverage 76.25% 76.17% -0.09%
==========================================
Files 87 87
Lines 7151 7164 +13
Branches 1057 1061 +4
==========================================
+ Hits 5453 5457 +4
- Misses 1374 1384 +10
+ Partials 324 323 -1
|
src/atomate2/vasp/flows/mp.py
Outdated
"IBRION": -1, | ||
"ISMEAR": -5, | ||
"LORBIT": 11, | ||
# "ICHARG": 0, # is this okay? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to test both runs with and without structure optimization. There could be differences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure will test these 😃
…nto add_lobster_mp_workflow sync remote
@utf , @naik-aakash has now finished this PR. It is a LOBSTER workflow that is compatible with our LOBSTER database. This might also be useful for future integration of data into the MP. We would be happy about another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JaGeo and @naik-aakash. All looks good to me.
One question I had that could maybe be clarified in the docs: what do you mean by MP compatible settings - I see you're changing the pseudo potential version to PBE_54?
Yes, you are right. We should maybe clarify that it is compatible with our Lobster database that will go into MP at some point. |
Thanks! |
Summary
This is an attempt to create an MP-compatible LOBSTER workflow.