Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future type annotations #580

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Future type annotations #580

merged 7 commits into from
Oct 19, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Oct 19, 2023

Follow up to #578. Make sure we use future type annotation in all non-schema files and bump ruff target version to 3.9.

@janosh janosh added ux User experience pkg Package health and distribution related stuff types Type all the things qa labels Oct 19, 2023
@janosh janosh enabled auto-merge October 19, 2023 22:29
@janosh janosh force-pushed the future-type-annos branch from 3a12d53 to 3401e29 Compare October 19, 2023 22:41
@janosh janosh force-pushed the future-type-annos branch from 3401e29 to 90b8d72 Compare October 19, 2023 22:59
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #580 (fde68d9) into main (109d9ef) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
+ Coverage   75.48%   75.49%   +0.01%     
==========================================
  Files          80       80              
  Lines        6722     6725       +3     
  Branches      992      992              
==========================================
+ Hits         5074     5077       +3     
  Misses       1342     1342              
  Partials      306      306              
Files Coverage Δ
src/atomate2/amset/schemas.py 0.00% <ø> (ø)
src/atomate2/cp2k/schemas/calculation.py 70.46% <100.00%> (+0.30%) ⬆️
src/atomate2/forcefields/jobs.py 92.37% <ø> (ø)
src/atomate2/settings.py 100.00% <100.00%> (ø)
src/atomate2/vasp/sets/base.py 74.87% <100.00%> (ø)

@janosh janosh merged commit a77db3c into main Oct 19, 2023
7 checks passed
@janosh janosh deleted the future-type-annos branch October 19, 2023 23:28
@utf utf added the house-keeping Formatting and code quality tweaks label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
house-keeping Formatting and code quality tweaks pkg Package health and distribution related stuff types Type all the things ux User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants