Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thomas Purcell to contributors.md #568

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

tpurcell90
Copy link
Contributor

@tpurcell90 tpurcell90 commented Oct 13, 2023

Suggested by @janosh to remove first time contributor status in #562

Summary

Add myself to the contributors list

Additional dependencies introduced (if any)

  • None

TODO (if any)

None

Checklist

Work-in-progress pull requests are encouraged, but please put [WIP] in the pull request
title.

Before a pull request can be merged, the following items must be checked:

  • Code is in the standard Python style.
    The easiest way to handle this is to run the following in the correct sequence on
    your local machine. Start with running black on your new code. This will
    automatically reformat your code to PEP8 conventions and removes most issues. Then run
    ruff.
  • Docstrings have been added in the Numpy docstring format.
    Run ruff on your code.
  • Type annotations are highly encouraged. Run mypy to
    type check your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply run
pre-commit install and a check will be run prior to allowing commits.

Suggested by @janosh to remove first time contributor label
Change Professor or Chemistry to of Chemistry
@JaGeo
Copy link
Member

JaGeo commented Oct 13, 2023

@janosh Very good suggestion, as always! Thanks!

@janosh janosh enabled auto-merge October 13, 2023 15:33
@janosh janosh changed the title Add myself to contributors.md Add Thomas Purcell to contributors.md Oct 13, 2023
@janosh janosh added the docs Improvements or additions to documentation label Oct 13, 2023
@janosh janosh merged commit 70f1ad6 into materialsproject:main Oct 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants