Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __all__ from all modules #540

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Remove __all__ from all modules #540

merged 1 commit into from
Oct 1, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Sep 30, 2023

Closes #539.

@janosh janosh added ecosystem Issues concerning the larger MP ecosystem breaking Breaking changes pkg Package health and distribution related stuff labels Sep 30, 2023
@janosh janosh marked this pull request as ready for review September 30, 2023 19:22
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #540 (bcb9757) into main (8c15179) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   75.25%   75.14%   -0.11%     
==========================================
  Files          74       74              
  Lines        6576     6523      -53     
  Branches      953      953              
==========================================
- Hits         4949     4902      -47     
+ Misses       1327     1321       -6     
  Partials      300      300              
Files Coverage Δ
src/atomate2/amset/files.py 0.00% <ø> (ø)
src/atomate2/amset/jobs.py 0.00% <ø> (ø)
src/atomate2/amset/run.py 0.00% <ø> (ø)
src/atomate2/amset/schemas.py 0.00% <ø> (ø)
src/atomate2/common/analysis/elastic.py 42.85% <ø> (-7.15%) ⬇️
src/atomate2/common/files.py 81.00% <ø> (-0.19%) ⬇️
src/atomate2/common/jobs/defect.py 85.60% <ø> (-0.12%) ⬇️
src/atomate2/common/jobs/phonons.py 84.70% <ø> (-0.18%) ⬇️
src/atomate2/common/jobs/utils.py 78.78% <ø> (-0.63%) ⬇️
src/atomate2/common/schemas/cclib.py 77.55% <ø> (-0.16%) ⬇️
... and 43 more

@utf utf added the house-keeping Formatting and code quality tweaks label Oct 1, 2023
@utf
Copy link
Member

utf commented Oct 1, 2023

Cheers!

@utf utf merged commit 19ec73a into main Oct 1, 2023
@janosh janosh deleted the drop-__all__ branch October 1, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes ecosystem Issues concerning the larger MP ecosystem house-keeping Formatting and code quality tweaks pkg Package health and distribution related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove __all__ to discourage wildcard imports
2 participants