Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed py38 support, and add py 3.11 support #537

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

naik-aakash
Copy link
Contributor

Changes

  1. Remove Python 3.8 support
  2. Add python 3.11

Closes #530

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #537 (77278db) into main (8c15179) will decrease coverage by 0.17%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   75.25%   75.09%   -0.17%     
==========================================
  Files          74       74              
  Lines        6576     6576              
  Branches      953      953              
==========================================
- Hits         4949     4938      -11     
- Misses       1327     1339      +12     
+ Partials      300      299       -1     

see 1 file with indirect coverage changes

@naik-aakash
Copy link
Contributor Author

Hi @janosh, I have tried to remove py38 support, but I cannot figure out why the workflows still point to py3.8 as the required test. Can you please point out what I am missing here?

@janosh
Copy link
Member

janosh commented Sep 29, 2023

That's not something you can change. @utf will have to update which CI is required when he merges this PR.

@utf
Copy link
Member

utf commented Oct 2, 2023

Thanks!

@utf utf merged commit e61510c into materialsproject:main Oct 2, 2023
@utf utf added the house-keeping Formatting and code quality tweaks label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
house-keeping Formatting and code quality tweaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with python 3.8 support with newer releases of dependencies
3 participants