-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add basic workflow tutorial #408
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
==========================================
- Coverage 64.95% 64.87% -0.08%
==========================================
Files 74 74
Lines 7193 7192 -1
Branches 946 947 +1
==========================================
- Hits 4672 4666 -6
- Misses 2221 2228 +7
+ Partials 300 298 -2 |
Looks great, @rkingsbury! One small comment, which may or may not be relevant for you. There is a package called cclib that is a community-driven file I/O parser for molecular DFT calculations. It is an optional dependency of Atomate2, and I made a It might be nice to add this somewhere just so people know about it, but you also don't need to if you don't want to. I wanted to bring it up. It'd be a shame if someone wastes their time making an I/O parser for something that already exists and is actively supported by the broader community. |
Thanks @arosen93 ! I made some updated per your suggestions, including adding language about I will leave further refinements to others that have more hands-on experience with |
@rkingsbury: Thanks!! Looks good to me! My $0.02 is that it looks good to merge and then people can add to it! |
Thanks @rkingsbury, this looks great. |
Summary
Draft "how to write a workflow tutorial" ported over from the WIP MP Contributor Guide