Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] For stringing defect calculations together #292

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Mar 31, 2023

remove while passing dir_name from bulk calculations

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #292 (3b05715) into main (de92307) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
- Coverage   65.90%   65.74%   -0.17%     
==========================================
  Files          73       73              
  Lines        7043     7044       +1     
  Branches      898      898              
==========================================
- Hits         4642     4631      -11     
- Misses       2137     2150      +13     
+ Partials      264      263       -1     
Impacted Files Coverage Δ
src/atomate2/vasp/flows/defect.py 82.60% <0.00%> (-1.22%) ⬇️

... and 1 file with indirect coverage changes

@jmmshn jmmshn marked this pull request as ready for review March 31, 2023 17:37
@utf
Copy link
Member

utf commented Apr 1, 2023

Thanks for this. Just fyi, I added a convenience function to do this: e.g.,

src_dir = strip_hostname(src_dir) # TODO: Handle hostnames properly.

@utf utf merged commit a5ead4f into materialsproject:main Apr 1, 2023
@utf utf added the fix Bug fix PR label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants