Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add has_doscar_lso field to Lobsterout schema model and update lobsterpy version #286

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

naik-aakash
Copy link
Contributor

@naik-aakash naik-aakash commented Mar 27, 2023

Summary

  • Added missing has_doscar_lso field to Lobsterout schema

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #286 (8fab9b6) into main (5cc544d) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 8fab9b6 differs from pull request most recent head c22f80a. Consider uploading reports for the commit c22f80a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   65.89%   65.73%   -0.16%     
==========================================
  Files          73       73              
  Lines        7039     7040       +1     
  Branches      897      897              
==========================================
- Hits         4638     4628      -10     
- Misses       2137     2149      +12     
+ Partials      264      263       -1     
Impacted Files Coverage Δ
src/atomate2/lobster/schemas.py 92.85% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@utf
Copy link
Member

utf commented Mar 27, 2023

Hi @naik-aakash

Please can you fix the linting error and then I can merge.

The easiest way to do this is to run:

pre-commit install
pre-commit run --all

@naik-aakash
Copy link
Contributor Author

Hi @naik-aakash

Please can you fix the linting error and then I can merge.

The easiest way to do this is to run:

pre-commit install
pre-commit run --all

Hi @utf , Thanks for the help. I was able to fix the issue and now it could be merged.

we also released a new version (0.2.9) of lobsterpy package , so version number of package is also updated

@naik-aakash naik-aakash changed the title Fix schema lsodos add has_doscar_lso field to Lobsterout schema model and update lobsterpy version Mar 28, 2023
@utf utf merged commit 4d5e6cb into materialsproject:main Mar 28, 2023
@utf utf added the enhancement Improvements to existing features label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants