Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: expanduser path #180

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Patch: expanduser path #180

merged 1 commit into from
Oct 14, 2022

Conversation

nwinner
Copy link
Contributor

@nwinner nwinner commented Oct 13, 2022

Most interpreters will not automatically recognize the tilde. Use pathlib to expand the tilde into the absolute path for the default config file.

Most interpreters will not automatically recognize the tilde. Use pathlib to expand the tilde into the true path.
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #180 (2502f33) into main (9b0435a) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   75.08%   74.85%   -0.24%     
==========================================
  Files          52       52              
  Lines        4704     4704              
  Branches      693      693              
==========================================
- Hits         3532     3521      -11     
- Misses        985      998      +13     
+ Partials      187      185       -2     
Impacted Files Coverage Δ
src/atomate2/settings.py 94.11% <0.00%> (ø)
src/atomate2/common/jobs.py 48.48% <0.00%> (-33.34%) ⬇️

@utf
Copy link
Member

utf commented Oct 14, 2022

Great thanks.

@utf utf merged commit e9b12c0 into materialsproject:main Oct 14, 2022
@nwinner nwinner deleted the patch-1 branch October 14, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants