Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure CI to use setup-python's built-in pip caching #142

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Configure CI to use setup-python's built-in pip caching #142

merged 1 commit into from
Jun 8, 2022

Conversation

janosh
Copy link
Member

@janosh janosh commented Jun 8, 2022

setup-python has built-in pip dependency caching.

Note caching was not working before as it used the hash of non-existent setup.py as the cache key.

Equivalent PR to pymatgen: materialsproject/pymatgen#2401

Also moves codespell pre-commit config to setup.cfg. I noticed setup.cfg was emptied in b82138e so I tried adding it to pyproject.toml instead but found that's not supported yet. Tracking issue: codespell-project/codespell#2055

Curious why did you decide to keep setup.cfg around?

@utf
Copy link
Member

utf commented Jun 8, 2022

Thanks!

Would you mind leaving the setup.cfg empty and putting the codespell stuff back in the precommit file?

Basically, I want to get rid of setup.cfg but at the moment it is still required by pip for editable installations (or alternatively you can use a basic setup.py file). See the warning at the top of this page: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #142 (c23dc88) into main (e95c50d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   73.14%   73.14%           
=======================================
  Files          49       49           
  Lines        4253     4253           
  Branches      672      672           
=======================================
  Hits         3111     3111           
  Misses        973      973           
  Partials      169      169           

@janosh
Copy link
Member Author

janosh commented Jun 8, 2022

Would you mind leaving the setup.cfg empty and putting the codespell stuff back in the precommit file?

Of course.

@utf utf merged commit 8578349 into materialsproject:main Jun 8, 2022
@utf
Copy link
Member

utf commented Jun 8, 2022

Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants