Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read API key from pymatgen config #856

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Conversation

janosh
Copy link
Member

@janosh janosh commented Oct 13, 2023

Brings behavior more in line with legacy rester in pymatgen.ext.matproj which looks for API key in ~/.config/.pmgrc.yaml if not passed explicitly.

@janosh janosh added the enhancement New feature or request label Oct 13, 2023
@munrojm
Copy link
Member

munrojm commented Oct 13, 2023

Thanks @janosh!

@janosh
Copy link
Member Author

janosh commented Oct 14, 2023

Test failure here seems unrelated

FAILED tests/materials/test_eos.py::test_client - mp_api.client.core.client.MPRestError: REST query returned with error status code 400 on URL https://api.materialsproject.org/materials/eos/?energies_min=-100.12&energies_max=100.12&_all_fields=True&_limit=1 with message:
Request contains query parameters which cannot be used: energies_min, energies_max
!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!
= 1 failed, 63 passed, 3 skipped, 3 xfailed, 251 warnings in 150.20s (0:02:30) =

@janosh janosh merged commit 9a971c2 into main Oct 17, 2023
@janosh janosh deleted the read-api-key-from-pmg-config branch October 17, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants