Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic model getattr for `MPDataDoc #764

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Apr 4, 2023

No description provided.

@munrojm munrojm added the release:patch Patch release label Apr 4, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 80.48% and project coverage change: -0.42 ⚠️

Comparison is base (98eb360) 81.05% compared to head (f445782) 80.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
- Coverage   81.05%   80.63%   -0.42%     
==========================================
  Files          36       36              
  Lines        1758     1782      +24     
==========================================
+ Hits         1425     1437      +12     
- Misses        333      345      +12     
Impacted Files Coverage Δ
mp_api/client/routes/alloys.py 52.63% <25.00%> (-6.20%) ⬇️
mp_api/client/core/client.py 89.21% <75.00%> (+0.02%) ⬆️
mp_api/client/routes/thermo.py 92.42% <85.71%> (-5.45%) ⬇️
mp_api/client/core/settings.py 92.00% <100.00%> (+0.33%) ⬆️
mp_api/client/mprester.py 58.91% <100.00%> (+0.11%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit 410627e into main Apr 4, 2023
@munrojm munrojm deleted the bugfix/dynamic_model_attr branch April 10, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants