Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default thermo_type in thermo search method #726

Merged
merged 9 commits into from
Jan 12, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jan 12, 2023

Ensure ThermoType.GGA_GGA_U is the default return type for all thermo data accessed through MPRester.thermo.search.

@munrojm munrojm added the release:patch Patch release label Jan 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Base: 81.18% // Head: 81.05% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (9b74ed4) compared to base (bebe77b).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   81.18%   81.05%   -0.13%     
==========================================
  Files          36       36              
  Lines        1759     1758       -1     
==========================================
- Hits         1428     1425       -3     
- Misses        331      333       +2     
Impacted Files Coverage Δ
mp_api/client/mprester.py 58.80% <0.00%> (-0.93%) ⬇️
mp_api/client/routes/thermo.py 97.87% <100.00%> (+2.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit 98eb360 into main Jan 12, 2023
@munrojm munrojm deleted the bugfix/default_thermo_type branch April 18, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants