Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#93 fixed sharing onOptionClick handler in multiple autocomplete instances #94

Merged

Conversation

bugy
Copy link

@bugy bugy commented Mar 24, 2021

This is a bugfix for #93

Proposed changes

As a part of this PR I make autocomplete options independent between instances

Also there is a fix in dropdown.js : _moveDropdown, which avoids adding a component to the same parent twice (it caused tests to fail, since on the second append a child was removed from a parent)

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Smankusors Smankusors linked an issue Mar 26, 2021 that may be closed by this pull request
@Smankusors Smankusors merged commit 58d1f53 into materializecss:v1-dev Mar 26, 2021
@Smankusors
Copy link
Member

Thanks for the bug fix and the new unit tests. We appreciate it 👍

@Smankusors Smankusors added the bug Something isn't working label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete share "onOptionClick" for multiple instances
2 participants