Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessibility(Autocomplete) implemented tab index and aria expanded #554

Open
wants to merge 2 commits into
base: v2-dev
Choose a base branch
from

Conversation

gselderslaghs
Copy link
Member

@gselderslaghs gselderslaghs commented Dec 15, 2024

Proposed changes

Implemented tab index and aria expanded as described in #538

Todo:

  • autocomplete functionality does not seem to be backward compatible with firefox < 113 and other older browsers (needs review) -> reviewed: won't fix for now, follow up in ticket and create new pull request when solution is found

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

wuda-io
wuda-io previously approved these changes Dec 21, 2024
@gselderslaghs gselderslaghs marked this pull request as ready for review January 19, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants