Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(all dispatchevent on components): make event propageable to work… #399

Merged

Conversation

InitialCrow
Copy link

@InitialCrow InitialCrow commented Jul 18, 2023

… with framework (e.g react)

Actualy materialize is broken on react and ember js due to non propageable event for e.g react overload default onchange event with onChange custom event since alpha release materialize not fired event due to non propageable event on components

fix #398

Proposed changes

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

… with framework (e.g react)

Actualy materialize is broken on react and ember js due to non propageable event for e.g react
overload default onchange event with onChange custom event since alpha release materialize not fired
event due to non propageable event on components

fix  materializecss#398
@InitialCrow InitialCrow changed the title feat(all dispatchevent on components): make event propageable to work… fix(all dispatchevent on components): make event propageable to work… Jul 18, 2023
@InitialCrow InitialCrow mentioned this pull request Jul 19, 2023
4 tasks
wuda-io
wuda-io previously approved these changes Jul 27, 2023
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please consider to merge into the DEV Branch next time. Thank you!

@wuda-io wuda-io changed the base branch from main to v2-dev July 27, 2023 16:47
@wuda-io wuda-io dismissed their stale review July 27, 2023 16:47

The base branch was changed.

@wuda-io wuda-io merged commit 7f2c1dc into materializecss:v2-dev Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: onChange Event not triggered on event inline html in React
2 participants