Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra indentation and trailing spaces #247

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

notSagyo
Copy link

@notSagyo notSagyo commented Jan 23, 2022

Proposed changes

  • Remove extra indentation and trailing spaces which serve no purpose from _waves.scss.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Smankusors Smankusors requested a review from a team January 24, 2022 14:26
@wuda-io
Copy link
Member

wuda-io commented Jan 24, 2022

Please update your commit-message to
refactor(waves): Remove extra indentation and trailing spaces
Also check out: https://commitlint.io/

@notSagyo
Copy link
Author

Please update your commit-message to refactor(waves): Remove extra indentation and trailing spaces Also check out: https://commitlint.io/

Commit message updated. Thank you for the heads up.

Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I hope we see also some code improvements from you in future,
not only space cleaning 😜

@DanielRuf DanielRuf merged commit 4800c83 into materializecss:main Jan 25, 2022
@DanielRuf
Copy link

Hi @notSagyo,

thanks for your contribution to materialize.
You should have received an invitation to @materializecss and the member group.

grafik

@notSagyo
Copy link
Author

notSagyo commented Jan 25, 2022

Hi @notSagyo,

thanks for your contribution to materialize. You should have received an invitation to @materializecss and the member group.

Thank you @DanielRuf,
I'll consider it, as I'm still getting used to the public GitHub environment and workflow !

@notSagyo notSagyo deleted the fix-indentation branch January 25, 2022 20:02
@Smankusors Smankusors added the enhancement New feature or request label Apr 6, 2022
DyegoCosta pushed a commit to DyegoCosta/materialize that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants