Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(getting_started): update the ways to install materialize #203

Merged
merged 3 commits into from
Oct 15, 2021
Merged

docs(getting_started): update the ways to install materialize #203

merged 3 commits into from
Oct 15, 2021

Conversation

LoganTann
Copy link

@LoganTann LoganTann commented Oct 6, 2021

Proposed changes

fixes #178 and took that opportunity to update the whole page. Requesting reviews.

  • 🆙 moved from bower:materialize to yarn:@materializecss/materialize (since bower is deprecated).
  • 🗑️ removed Meteor and Ember packages (since they are using 0.100)

Screenshots (if appropriate) or codepen:

Reading the diffs should do the job 😀.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).
  • docs

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- moved from `bower:materialize` to `yarn:@materializecss/materialize`
- removed Meteor and Ember packages (since they are using 0.100)
Copy link
Member

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoganTann
Copy link
Author

LoganTann commented Oct 6, 2021

b5f4528 -> is it safe to delete package.js ?
It seems it's only used in meteor package manager and we deleted it in the docs

@Smankusors Smankusors requested a review from DanielRuf October 6, 2021 16:23
@LoganTann LoganTann requested a review from DanielRuf October 9, 2021 13:25
@LoganTann
Copy link
Author

Requesting reviews for this PR to be merged.

@DanielRuf DanielRuf requested a review from a team October 12, 2021 09:37
@DanielRuf
Copy link

Requesting reviews for this PR to be merged.

In this case please choose materializecss/members then =)
I've done that now.

Anyone with write permissions should be able to merge then. cc @materializecss/members-write-access @materializecss/maintainers

@Smankusors Smankusors merged commit 8e3c315 into materializecss:main Oct 15, 2021
@Smankusors Smankusors added the documentation Improvements or additions to documentation label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the (very deprecated) ember package from the getting started documentation page
4 participants