feat(datepicker): add possibility for a format function to Datepicker #153
Conversation
There was a problem hiding this comment.
LGTM. Well, the check failing because there's a problem with your commit messages
What do you think about these commit messages? @ChildishGiant
|
It's just an issue of the case, which doesn't overly matter. I might change the action to only give a warning as it's not a massive deal if the commits aren't the right style. |
|
Should a format-function not have a |
hmm wait, I don't get it. What do you mean? |
Haven't yet looked at your pull request, but I guess it's probably already possible: M.Datepicker.init(elems, {
format: (date, fmt) => new Intl.DateTimeFormat(locale, fmt).format(date)
}); |
|
@ray007 and what value should the If you add a format function, why should it not be possible for that function to know how to format itself? |
Calamari
force-pushed
the
datepicker_format
branch
2 times, most recently
from
bfa957a to
5ad735c
Compare
Calamari
changed the title
Calamari
force-pushed
the
datepicker_format
branch
from
5ad735c to
27620cc
Compare
|
So, I finally fixed those commit linting problems :-) |
To leverace browser own internationalization methods, it is useful
to add a format method instead of simple format string. That makes
things like this possible:
```js
M.Datepicker.init(elems, {
format: date => new Intl.DateTimeFormat(locale).format(date)
});
```
Which would format the input according to the i18n rules defined
by the browser using the locale of the user.
Calamari
force-pushed
the
datepicker_format
branch
from
27620cc to
88c0b7e
Compare
|
So, let's see if I can finally pass the bouncer of a commit linter. |
|
Anyone like to approve the workflow? :-) |
As far as I can see it was already approved and successfully finished (2 successful checks).
|
Oh yeah, I did approve it. Hmm.... I assume the issue that mentioned by @ray007 is already solved (there is no reply since a month). Merging it now. |
|
Anyway, I sent an invitation to you to join the @materializecss/members team. Welcome 🎉 |
|
To me it said, it waited for approval for the workflows, that's why I wrote again. :-) |
I have probably manually triggered them a few days or weeks ago. |
Proposed changes
This is described in #151. In short: This adds the ability to add a formatting function as format option to datepicker instance, which allows things like this:
Types of changes
Checklist: