Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): invalid download sass link #128

Merged
merged 1 commit into from
May 4, 2021

Conversation

roiLeo
Copy link
Member

@roiLeo roiLeo commented May 4, 2021

close #127

@roiLeo roiLeo changed the title fix(doc): invalid link sass fix(doc): invalid download sass link May 4, 2021
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielRuf DanielRuf merged commit abb5631 into materializecss:v1-dev May 4, 2021
@Smankusors
Copy link
Member

wait, what? Nooo............ what's the purpose of 2 buttons leading to the same link? 😞

That button should lead to https://github.com/materializecss/materialize/archive/refs/tags/1.1.0-alpha.zip, because the OP wanted the SASS/SCSS files, not the compiled one.

@DanielRuf
Copy link

DanielRuf commented May 4, 2021

wait, what? Nooo............ what's the purpose of 2 buttons leading to the same link? disappointed

Good catch.

Can you provide a new PR @roiLeo?
I've reverted it in #129

@Smankusors
Copy link
Member

Smankusors commented May 4, 2021

IMO, I would just commit the updated link without PR, we don't need to revert it.


@DanielRuf So, do you allow me to do that, or let @roiLeo fix the link via PR?

@DanielRuf
Copy link

IMO, I would just commit the updated link without PR, we don't need to revert it.

See my last comment. I already reverted it.
A PR should be the way to go so it goes through the review process.
I think we should make the current v1-dev branch protected to allow only changes by PRs.

We are not in a hurry so we can wait for a PR.

@roiLeo
Copy link
Member Author

roiLeo commented May 4, 2021

Original repo had 2 two .zip in last release, one with compiled css/js (materialize.css and materialize.js) and the other one with uncompiled sass/js files.
Maybe we should remove the sass download links, as we do not currently provide an archive containing sass files.

@ChildishGiant
Copy link
Member

well github still generates a source code zip that we could use? If we want to make a proper src zip like they have with all the extras not included, we should build it into the release script.

@wuda-io
Copy link
Member

wuda-io commented May 4, 2021

Yes, the best solution is to generate the link out of the Process, otherwise we will face the same issue again at the nexr Release.

@Smankusors
Copy link
Member

Yes, the best solution is to generate the link out of the Process, otherwise we will face the same issue again at the nexr Release.

the release process is just search "old version string" and replace it with "new version string". So as long as the link have similarity, I think it should be fine.

@ChildishGiant
Copy link
Member

I more mean make the script generate these zips, not just making them by hand each time.

@Smankusors
Copy link
Member

hmm... or maybe just point the link to the github repo? Instead of src zip file?

@Smankusors Smankusors added the documentation Improvements or additions to documentation label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid link for Sass version
5 participants