-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(doc): invalid download sass link #128
fix(doc): invalid download sass link #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wait, what? Nooo............ what's the purpose of 2 buttons leading to the same link? 😞 That button should lead to https://github.com/materializecss/materialize/archive/refs/tags/1.1.0-alpha.zip, because the OP wanted the SASS/SCSS files, not the compiled one. |
IMO, I would just commit the updated link without PR, we don't need to revert it. @DanielRuf So, do you allow me to do that, or let @roiLeo fix the link via PR? |
See my last comment. I already reverted it. We are not in a hurry so we can wait for a PR. |
Original repo had 2 two .zip in last release, one with compiled css/js (materialize.css and materialize.js) and the other one with uncompiled sass/js files. |
well github still generates a source code zip that we could use? If we want to make a proper src zip like they have with all the extras not included, we should build it into the release script. |
Yes, the best solution is to generate the link out of the Process, otherwise we will face the same issue again at the nexr Release. |
the release process is just search "old version string" and replace it with "new version string". So as long as the link have similarity, I think it should be fine. |
I more mean make the script generate these zips, not just making them by hand each time. |
hmm... or maybe just point the link to the github repo? Instead of src zip file? |
close #127