Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim select text #100

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Trim select text #100

merged 1 commit into from
Mar 31, 2021

Conversation

richarddewit
Copy link

A fix provided in Dogfalo#6142 to fix Dogfalo#3249

CC of said PR:

Proposed changes

Fixes Dogfalo#3249.

Screenshots:

Code:

<option>
    Nachmittag
</option>

Before:
screenshot_2018-09-28 youtube-adventskalender 1

After:
screenshot_2018-09-28 youtube-adventskalender

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A fix provided in Dogfalo#6142 to fix Dogfalo#3249
@DanielRuf DanielRuf requested a review from a team March 31, 2021 08:55
Copy link
Member

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richarddewit
Copy link
Author

Hey thanks for the merge. I don't think this is the correct place for this, but there's this:

  1. the compiled file in the dist folder is outdated (I guess it's intentional)
  2. how do I import all the separate JS files to create a materialize.js file to use in my project? I can't get past the
    Uncaught ReferenceError: Component is not defined

@Smankusors
Copy link
Member

  1. the compiled file in the dist folder is outdated (I guess it's intentional)

yes it is.

  1. how do I import all the separate JS files to create a materialize.js file to use in my project? I can't get past the
    Uncaught ReferenceError: Component is not defined

you can grab the latest build artefact for that instead : https://github.com/materializecss/materialize/suites/2389918062/artifacts/50779264
(from https://github.com/materializecss/materialize/runs/2237561283)

@ChildishGiant
Copy link
Member

  1. how do I import all the separate JS files to create a materialize.js file to use in my project? I can't get past the
    Uncaught ReferenceError: Component is not defined

This is an ongoing issue with the library that we'd like to fix. For me details see #44

@Smankusors Smankusors added the bug Something isn't working label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Material Select "offsets" text when leading or trailing whitespace is present
5 participants