Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement/Accessibility]: Consider using button with SASS mixin for pagination #566

Open
3 tasks done
Tracked by #543
gselderslaghs opened this issue Dec 26, 2024 · 0 comments
Open
3 tasks done
Tracked by #543

Comments

@gselderslaghs
Copy link
Member

Before submitting...

Context

This issue is a follow up of #543 (#81)

Replace Pagination links with buttons because we could optimally use the existing global buttons styling and it would comply with Material M3 standards

Here is a Codepen example where we have button styling applied to pagination (enhancement regarding to M3 guidelines and accessibility)
I needed to add additional btn class but if we consider implementing the buttons styling as a mixin on top of the current CSS classes we could avoid adding additional classes and implement it in the SCSS setup, as a result no documentation update would be required and it would be backwards compatible, users can define additional button styles if desired

This enhancement would also improve adaption to the theme as theme switch will take theme vars into account, which is not the case with the current component specific styling

Current Behavior

Pagination has component based styling on the elements states (focus, active)

Expected behavior

From the Material M3 standards we could enhance this functionality with adding buttons with global styling instead of basic html links with component based styling

Possible Solutions or Causes

With minimal effort replace Pagination interactive links with buttons in SCSS setup, migrate basic button styling class to SCSS and apply it to the HTML a elements inside the pagination component

Your Environment

  • Version used: v2.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant