-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Discovery needs better documentation #252
Comments
Also it seems to only work when the element is set as display: inline; and not anything else |
Hi there, improving the documentation is one of the top priorities of the project maintainers. I myself have had some huge issues trying to understand how to implement some of the features (date picker mainly). I will add it to the maintainers discussions. |
Worst case scenario under some of the more problematic ones we can add a link to a working codepen as a demo for someone to build off of |
Hello! Perhaps you already solved the issues you were facing. But I'd like to post here that the "menu" element needs You can also check out my codepen: https://codepen.io/iBeliakov/pen/Yzvogoa |
It should be not necessary to manually trigger the element opening inside your custom scripts, the current setup of the component lacks this functionality I'm currently working on a fix that should initialize every Feature Discovery component on the page where click handlers for Feature Discovery components will be programmatically fired |
Changelog This feature is ready for review in pull-request #537 |
This has been pushed in v2.2.1, I don't think it needs better documentation from this point |
Looks good on my end, thanks a lot 👍 |
I have been having a very hard time figuring out how to use the feature discovery and how to chain multiple of them together to make a walkthrough.
I really wish we had better examples that were full and showed how to use it. For example, I kept doing instances.open( ) and kept getting "method does not exist" error, after an hour of debugging I found out that its instances[0].open( ). I think our documentation could use some improvement to make it simpler for any of us to understand.
Here is the gist that I am currently struggling with to create a walkthrough for a new user
https://gist.github.com/nh916/b2a7512fbe9b4d24de8c5f909a7c6053
The text was updated successfully, but these errors were encountered: