Fix disabled folder animations for all themes

[anhuynh]

Description

Fixes disabled folder animations for all themes. Disabled folder animation code for all accent colours were added back that was deleted in b7446c2. Also adds missing disabled folder animation code for the newer accent colours. Little bit of spelling also fixed in the README.

Motivation and Context

b7446c2 did not actually fix #943 properly. I noticed that even when I had folder animations disabled and using the dark or light theme, the animations were still there. Additionally, on the default theme, all accents would have the default teal coloured folder when hovering over with folder animations disabled (see screenshot).

How Has This Been Tested?

I installed the changed theme over the old themes and then checked most of the accents on each of the themes to ensure that the folder animation worked.

Screenshots (if appropriate):

Using Default theme with red accent:

I don't have a gif of the disabled folder animation issue on the Darker and Lighter themes.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.

[diego1araujo]

I've tested all accent colors in the current version named v3.1.8 on ST3 3114/Windows 10 and it looks like is everything ok.

Can you say which version of MT, ST and OS you are running?

[anhuynh]

@diego1araujo That's weird. I first noticed the issue on v3.1.7 on OSX 10.11.6/ST3 3114. I can also see the behaviour on my Windows 10/ST3 3114 too. Did you disable folder animations? Cause that's where the issue happens.

[diego1araujo]

Ohh, now I see. You wrote "Default theme" but picture example seems like Darker theme. That confused me hard.

Yes, on default it happens. This might be merged soon. 👍

[anhuynh]

Yeah, there's also an issue with the Darker and Lighter themes too. Disabling folder animations on those themes don't do anything. This fixes that as well as the screenshotted issue on the Default theme.

[equinusocio]

Thanks! :)