Add the option of a default filter operator and fix filters #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2024
|
Hi thanks for this. |
cococov
force-pushed
the
feature/default-filter-operator-for-url-params
branch
from
dcfb24f to
6101c3d
Compare
It's not really a problem, because if it's not added, the default behavior is '='. I added it anyway to prevent it from being undefined. The change is already up! ( |
|
Ok I'll merge after the console log is removed 😉 |
cococov
force-pushed
the
feature/default-filter-operator-for-url-params
branch
from
6101c3d to
6ad4d5c
Compare
Oh! My bad 😅. Done! the change is up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fix: #847 #843
Description
Feature: Previously, I contributed a feature that allowed operators in the table filters. Now, I am adding the option to have a default operator for each column, enabling things like saving the operator in the URL query parameters
Fix: While developing this feature, I noticed a bug with the filters that prevented me from testing my feature. I also saw that there were issues related to it. So, I fixed it. (I recommend taking a look at the commit that introduced the problem, because it's a large refactor and, just as this was missed, something else might have been overlooked.)
Impacted Areas in Application
Additional Notes
I included the fix in this PR so it can be tested easily without waiting for another PR to be merged.