Fix TypeScript type for maxColumnSort to match prop-types #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, you get a TS error trying to set `maxColumnSort` to 0, which prevents you from turning off sorting. This adds 0 as an option, like it is with the `PropTypes` definition here https://github.com/material-table-core/core/blob/8dc35d85df2f87a77d067cae1fa5713fbb465f82/src/prop-types.js#L387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
n/a
Description
Without this, you get a TS error trying to set
maxColumnSortto 0, which prevents you from turning off sorting. This adds 0 as an option, like it is with thePropTypesdefinition herecore/src/prop-types.js
Lines 387 to 400 in 8dc35d8
Impacted Areas in Application
TypeScript usage of the
MaterialTableoptions.