This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
Add unit tests verifying that the presented controller's frame matches the expected frame #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romoore
approved these changes
Nov 14, 2017
| } | ||
| } | ||
|
|
||
| final class PresentationTransition: NSObject, TransitionWithPresentation { |
There was a problem hiding this comment.
Rename to "TestingPresentationTransition"?
| waitForExpectations(timeout: 0.1) | ||
|
|
||
| XCTAssertEqual(window.rootViewController!.presentedViewController, presentedViewController) | ||
| XCTAssertEqual(window.rootViewController!.presentedViewController?.view.bounds, window.bounds) |
There was a problem hiding this comment.
Does make sense to check the view's frame against the window's bounds? Also, this test method name should be updated to reflect frame/bounds.
| func testNoFramesModifiedWhenThereIsAPresentationView() { | ||
| let presentedViewController = UIViewController() | ||
| let transition = PresentationTransition() | ||
| let presentationView = UIView() |
There was a problem hiding this comment.
Nit: designated iniitalizer initWithFrame?
| override var frameOfPresentedViewInContainerView: CGRect { | ||
| if let presentationFrame = presentationFrame { | ||
| return presentationFrame | ||
| } |
There was a problem hiding this comment.
This hurts my head. I need to learn more swift.
added 3 commits
November 30, 2017 12:43
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #55.
Also fixes an existing test that said it was testing the non-animated route.