This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
Spring animations now take velocity into account when determining duration. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2017 13:28
…ation. Prior to this change, spring animations were calculating their settling time prior to having set their initial velocity. After this change, spring animations will calculate their settling time after having set the initial velocity.
romoore
reviewed
Nov 22, 2017
| #pragma clang diagnostic push | ||
| #pragma clang diagnostic ignored "-Wpartial-availability" | ||
| if ([animation isKindOfClass:[CASpringAnimation class]]) { | ||
| CASpringAnimation *springAnimation = (CASpringAnimation *)animation; |
There was a problem hiding this comment.
Is referencing the class before it was introduced OK? I believe CASpringAnimation was introduced in iOS 9?
https://developer.apple.com/documentation/quartzcore/caspringanimation
There was a problem hiding this comment.
Not strictly an encouraged behavior, no. But this allows us to expand our min SDK support to iOS 8. Is a trade-off, but a relatively safe one.
There was a problem hiding this comment.
Ok. As long as it doesn't crash with undefined symbols (or generate compiler errors). Sounds good to me.
romoore
approved these changes
Nov 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, spring animations were calculating their settling time prior to having set their initial velocity.
After this change, spring animations will calculate their settling time after having set the initial velocity.