Don't animate system views with the animator. (#119)

* Don't animate system views with the animator. Notably, animating the status bar with the animator can cause all of the status bar elements to animate. This is not desirable and deviant from UIKit's implicit animator behavior, but at this time I don't see a way to mimic the same behavior without regressing on our support for animating unhosted layers. * Remove unused spec item.
material-motion · Mar 8, 2018 · c805783 · c805783
1 parent d2f5971
commit c805783
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 9 deletions.
diff --git a/examples/CalendarCardExpansionExample.m b/examples/CalendarCardExpansionExample.m
@@ -48,9 +48,7 @@ - (void)didTap {
   animator.shouldReverseValues = !_expanded;
   animator.beginFromCurrentState = YES;
 
-  [animator animateWithTraits:traits.navigationBarY animations:^{
-    [self.navigationController setNavigationBarHidden:_expanded animated:YES];
-  }];
+  [self.navigationController setNavigationBarHidden:_expanded animated:YES];
 
   CGRect chipFrame = [self frameForChip];
   CGRect headerFrame = [self frameForHeader];

diff --git a/examples/CalendarChipMotionSpec.h b/examples/CalendarChipMotionSpec.h
@@ -26,8 +26,6 @@
 @property(nonatomic, strong, nonnull, readonly) MDMAnimationTraits *chipContentOpacity;
 @property(nonatomic, strong, nonnull, readonly) MDMAnimationTraits *headerContentOpacity;
 
-@property(nonatomic, strong, nonnull, readonly) MDMAnimationTraits *navigationBarY;
-
 @end
 
 @interface CalendarChipMotionSpec: NSObject

diff --git a/examples/CalendarChipMotionSpec.m b/examples/CalendarChipMotionSpec.m
@@ -80,10 +80,6 @@ - (MDMAnimationTraits *)headerContentOpacity {
   return [[MDMAnimationTraits alloc] initWithDelay:0.000 duration:0.075 timingCurve:LinearTimingCurve()];
 }
 
-- (MDMAnimationTraits *)navigationBarY {
-  return [[MDMAnimationTraits alloc] initWithDelay:0.045 duration:0.150 timingCurve:StandardTimingCurve()];
-}
-
 @end
 
 @implementation CalendarChipMotionSpec