[refactored] appendUnit to use named args

Summary: Continuation of #193 Reviewers: O2 Material Motion, O3 Material JavaScript platform reviewers, #material_motion, vietanh Reviewed By: #material_motion, vietanh Subscribers: vietanh Tags: #material_motion Differential Revision: http://codereview.cc/D3409
material-motion · Oct 11, 2017 · 888f3df · 888f3df
1 parent 2d8892f
commit 888f3df
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/core/src/operators/__tests__/appendUnit.test.ts b/packages/core/src/operators/__tests__/appendUnit.test.ts
@@ -52,7 +52,7 @@ describe('motionObservable.appendUnit',
 
     it('should append the given unit to the upstream values',
       () => {
-        stream.appendUnit('px').subscribe(listener);
+        stream.appendUnit({ unit: 'px' }).subscribe(listener);
 
         mockObserver.next(50);
 

diff --git a/packages/core/src/operators/appendUnit.ts b/packages/core/src/operators/appendUnit.ts
@@ -20,8 +20,12 @@ import {
   ObservableWithMotionOperators,
 } from '../types';
 
+export type AppendUnitArgs = {
+  unit: string,
+}
+
 export interface MotionAppendUnitable {
-  appendUnit(unit: string): ObservableWithMotionOperators<string>;
+  appendUnit(kwargs: AppendUnitArgs): ObservableWithMotionOperators<string>;
 }
 
 export function withAppendUnit<T, S extends Constructor<MotionMappable<T>>>(superclass: S): S & Constructor<MotionAppendUnitable> {
@@ -30,7 +34,7 @@ export function withAppendUnit<T, S extends Constructor<MotionMappable<T>>>(supe
      * Converts a stream to a CSS string representation by appending the given
      * unit to the upstream values.
      */
-    appendUnit(unit: string): ObservableWithMotionOperators<string> {
+    appendUnit({ unit }: AppendUnitArgs): ObservableWithMotionOperators<string> {
       return this._map({
         transform: (value: T) => value + unit
       });