This repository has been archived by the owner on Aug 13, 2021. It is now read-only.
Implement MotionRuntime.interactions() API #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New |
Codecov Report
@@ Coverage Diff @@
## develop #75 +/- ##
==========================================
Coverage ? 25.46%
==========================================
Files ? 70
Lines ? 962
Branches ? 65
==========================================
Hits ? 245
Misses ? 714
Partials ? 3
Continue to review full report at Codecov.
|
pingpongboss
suggested changes
Apr 24, 2017
| @@ -31,6 +32,7 @@ | |||
|
|
|||
| private final List<Subscription> subscriptions = new ArrayList<>(); | |||
| private final SimpleArrayMap<View, ReactiveView> cachedReactiveViews = new SimpleArrayMap<>(); | |||
| private final SimpleArrayMap<Object, ArrayList<Interaction>> cachedInteractions = new SimpleArrayMap<>(); | |||
There was a problem hiding this comment.
Use List<Interaction for all definitions instead of ArrayList<Interaction>
| @@ -62,6 +64,13 @@ public void next(T value) { | |||
| public final <O, T> void addInteraction( | |||
| Interaction<O, T> interaction, O target, ConstraintApplicator<T> constraints) { | |||
| interaction.apply(this, target, constraints); | |||
| ArrayList<Interaction> interactions = cachedInteractions.get(target); | |||
sample/build.gradle
Outdated
| @@ -39,4 +39,7 @@ dependencies { | |||
| compile "com.android.support:appcompat-v7:$supportLibVersion" | |||
| compile "com.android.support:recyclerview-v7:$supportLibVersion" | |||
| compile 'pl.droidsonroids.gif:android-gif-drawable:1.2.5' | |||
| testCompile 'com.google.truth:truth:0.28' | |||
| testCompile 'junit:junit:4.12' | |||
| testCompile 'org.robolectric:robolectric:3.1.2' | |||
There was a problem hiding this comment.
can you remove these too?
Summary: Fetches interactions associated with a given target. Fixes #74 Tags: #material_motion
pingpongboss
approved these changes
Apr 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fetches interactions asociated with a givent target.
Fixes #74
Tags: #material_motion