Rename noopDisconnection to noopDisconnect.

Reviewers: chuga, O4 Material Apple platform reviewers, O2 Material Motion, #material_motion

Reviewed By: chuga, O4 Material Apple platform reviewers

Subscribers: chuga

Tags: #material_motion

Differential Revision: http://codereview.cc/D2242

README.md

@@ -89,7 +89,7 @@ final class ValueObservable<T>: IndefiniteObservable<ValueObserver<T>> {
 ```swift
 let observable = ValueObservable<<#ValueType#>> { observer in
   observer.next(<#value#>)
-  return noopDisconnection
+  return noopDisconnect
 }
 ```
 

examples/OperatorExample.swift

@@ -119,7 +119,7 @@ public class OperatorExampleViewController: UIViewController {
     let motionStream = MotionObservable<Int> { observer in
       observer.next(5)
       observer.state(.atRest)
-      return noopDisconnection
+      return noopDisconnect
     }
 
     // Note that we avoid keeping a strong reference to self in the stream's operators.

src/IndefiniteObservable.swift

@@ -25,7 +25,7 @@
 
      let observable = IndefiniteObservable<Int> { observer in
        observer.next(5)
-       return noopDisconnection
+       return noopDisconnect
      }
 
      let subscription = observable.subscribe { value in
@@ -99,14 +99,14 @@ public final class Subscription {
 }
 
 /**
- A no-op disconnection that can be returned by connectors when there is no need for teardown.
+ A no-op disconnect block that can be returned by connectors when there is no need for teardown.
 
  Example:
 
      let observable = IndefiniteObservable<Int> { observer in
        observer.next(5)
 
-       return noopDisconnection
+       return noopDisconnect
      }
  */
-public let noopDisconnection: Disconnect = { }
+public let noopDisconnect: Disconnect = { }

tests/unit/MemoryLeakTests.swift

@@ -22,7 +22,7 @@ class MemoryLeakTests: XCTestCase {
   func testObservableIsDeallocated() {
     var observable: ValueObservable<CGFloat>? = ValueObservable<CGFloat> { observer in
       observer.next(5)
-      return noopDisconnection
+      return noopDisconnect
     }
     weak var weakObservable = observable
 
@@ -39,7 +39,7 @@ class MemoryLeakTests: XCTestCase {
   func testDownstreamObservableKeepsUpstreamAlive() {
     var observable: ValueObservable<CGFloat>? = ValueObservable<CGFloat> { observer in
       observer.next(5)
-      return noopDisconnection
+      return noopDisconnect
     }
     weak var weakObservable = observable
 
@@ -58,7 +58,7 @@ class MemoryLeakTests: XCTestCase {
   func testSubscribedObservableIsDeallocated() {
     var observable: ValueObservable<CGFloat>? = ValueObservable<CGFloat> { observer in
       observer.next(5)
-      return noopDisconnection
+      return noopDisconnect
     }
     weak var weakObservable = observable
 
@@ -78,7 +78,7 @@ class MemoryLeakTests: XCTestCase {
   func testSubscribedObservableWithOperatorIsDeallocated() {
     var observable: ValueObservable<CGFloat>? = ValueObservable<CGFloat> { observer in
       observer.next(5)
-      return noopDisconnection
+      return noopDisconnect
     }
     weak var weakObservable = observable
 
@@ -102,7 +102,7 @@ class MemoryLeakTests: XCTestCase {
     autoreleasepool {
       let observable: ValueObservable<CGFloat>? = ValueObservable<CGFloat> { observer in
         observer.next(5)
-        return noopDisconnection
+        return noopDisconnect
       }
       weakObservable = observable
 
@@ -128,7 +128,7 @@ class MemoryLeakTests: XCTestCase {
       let value = 10
       let observable = ValueObservable<Int> { observer in
         observer.next(value)
-        return noopDisconnection
+        return noopDisconnect
       }
       weakObservable = observable
 

tests/unit/ObservableTests.swift

@@ -25,7 +25,7 @@ class ObservableTests: XCTestCase {
 
     let observable = ValueObservable<Int> { observer in
       observer.next(value)
-      return noopDisconnection
+      return noopDisconnect
     }
 
     let wasReceived = expectation(description: "Value was received")
@@ -74,7 +74,7 @@ class ObservableTests: XCTestCase {
 
     let observable = ValueObservable<Int> { observer in
       observer.next(value)
-      return noopDisconnection
+      return noopDisconnect
     }
 
     let wasReceived = expectation(description: "Value was received")
@@ -99,7 +99,7 @@ class ObservableTests: XCTestCase {
 
     let observable = ValueObservable<Int> { observer in
       observer.next(value)
-      return noopDisconnection
+      return noopDisconnect
     }
 
     let wasReceived = expectation(description: "Value was received")
@@ -126,7 +126,7 @@ class ObservableTests: XCTestCase {
     let value = 10
     let observable = ValueObservable<Int> { observer in
       observer.next(value)
-      return noopDisconnection
+      return noopDisconnect
     }
 
     let wasReceived = expectation(description: "Value was received")
@@ -143,7 +143,7 @@ class ObservableTests: XCTestCase {
     let value = CGPoint(x: 0, y: 10)
     let observable = ValueObservable<CGPoint> { observer in
       observer.next(value)
-      return noopDisconnection
+      return noopDisconnect
     }
 
     let wasReceived = expectation(description: "Value was received")
@@ -161,7 +161,7 @@ class ObservableTests: XCTestCase {
     let observable = ValueObservable<(Bool, CGPoint)> { observer in
       observer.next(false, value)
       observer.next(true, value)
-      return noopDisconnection
+      return noopDisconnect
     }
 
     var filteredValues: [CGPoint] = []