Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): add missing sass imports #5363

Merged

Conversation

jason2506
Copy link
Contributor

No description provided.

Copy link

google-cla bot commented Jan 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@asyncLiz
Copy link
Collaborator

asyncLiz commented Jan 3, 2024

I don't believe these files use Sass's list module, so the imports are not needed

@jason2506
Copy link
Contributor Author

sass:list module is needed for the @theme mixins. Without this, I will get below error during build:

Error: There is no module with the namespace "list".
   ╷
14 │     $supported-tokens: list.join(
   │ ┌──────────────────────^
15 │ │     tokens.$md-comp-text-button-supported-tokens,
16 │ │     (
17 │ │       'container-shape-start-start',
18 │ │       'container-shape-start-end',
19 │ │       'container-shape-end-end',
20 │ │       'container-shape-end-start'
21 │ │     )
22 │ │   );
   │ └───^

Copy link
Collaborator

@asyncLiz asyncLiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh gotcha, thank you for catching this!

@asyncLiz
Copy link
Collaborator

asyncLiz commented Jan 4, 2024

Just need you to take a look at the CLA and then we can import :)

@jason2506
Copy link
Contributor Author

Done. Thank you for reviewing :)

@copybara-service copybara-service bot merged commit ad52075 into material-components:main Jan 4, 2024
3 of 4 checks passed
@jason2506 jason2506 deleted the fix-button-sass-imports branch January 30, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants