Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chip): trailing remove icon can now be customized #5263

Merged
merged 7 commits into from
Dec 12, 2023
Merged

feat(chip): trailing remove icon can now be customized #5263

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a4bfc96
chore(md-chip): filter chip trailing icon can now be customized
vdegenne Dec 6, 2023
9ff29ac
chore(md-chip): filter chip trailing icon can now be customized
vdegenne Dec 6, 2023
b30d09e
add hasSlottedTrailingIcon
vdegenne Dec 6, 2023
2a4db32
Merge branch 'main' into md-filter-chip-icons
vdegenne Dec 9, 2023
76883cd
feat(chip): trailing remove icon can now be customized
vdegenne Dec 9, 2023
49a6be1
feat(chip): trailing remove icon can now be customized
vdegenne Dec 12, 2023
b44b90c
feat(chip): trailing remove icon can now be customized
vdegenne Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions chips/internal/trailing-icons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,14 @@ export function renderRemoveButton({
@focus=${focusListener}>
<md-focus-ring part="trailing-focus-ring"></md-focus-ring>
<md-ripple ?disabled=${disabled}></md-ripple>
<svg class="trailing icon" viewBox="0 96 960 960" aria-hidden="true">
<path
d="m249 849-42-42 231-231-231-231 42-42 231 231 231-231 42 42-231 231 231 231-42 42-231-231-231 231Z" />
</svg>
<span class="trailing icon">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is 🤌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\ o / I like how it reverted to just that

<slot name="remove-trailing-icon">
<svg viewBox="0 96 960 960" aria-hidden="true">
<path
d="m249 849-42-42 231-231-231-231 42-42 231 231 231-231 42 42-231 231 231 231-42 42-231-231-231 231Z" />
</svg>
</slot>
</span>
<span class="touch"></span>
</button>
`;
Expand Down