Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README for mwc-fab #361

Merged
merged 2 commits into from
Aug 13, 2019
Merged

README for mwc-fab #361

merged 2 commits into from
Aug 13, 2019

Conversation

aomarks
Copy link
Contributor

@aomarks aomarks commented Aug 13, 2019

Be sure to click ... > View file to see the rendered version.

Also updates all demos to load the correct Roboto font widths, and updates the FAB demo to match the examples in the README.

#348

@aomarks aomarks requested a review from e111077 August 13, 2019 01:29
Copy link
Contributor

@e111077 e111077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you npmignore the images?

Also updates all demos to load the correct Roboto font widths, and
updates the FAB demo to match the examples in the README.
@aomarks
Copy link
Contributor Author

aomarks commented Aug 13, 2019

Can you npmignore the images?

Ok, I added an .npmignore to every package (as recommended here lerna/lerna#296 (comment)).

In a follow up, I'm planning to write a prepack script that replaces all the local image references with github URLs, so that these READMEs render correctly on npmjs.com even without the images being part of the tarball.

@aomarks aomarks merged commit 5bb2eaa into master Aug 13, 2019
@aomarks aomarks deleted the fab-readme branch August 13, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants