This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
test(icon-button): Add Jasmine component unit tests #5456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 289179697
allan-chen
changed the title
Project import generated by Copybara.
test(icon-button): Add Jasmine component unit tests
Jan 10, 2020
All 320 screenshot tests passed for commit ee17431 vs. |
All 320 screenshot tests passed for commit 3c5f4b9 vs. |
All 320 screenshot tests passed for commit f1a53c3 vs. |
abhiomkar
suggested changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unwanted changes from this PR.
Seems to be out of sync files from #5448 |
All 320 screenshot tests passed for commit 6112f1e vs. |
joyzhong
approved these changes
Jan 14, 2020
abhiomkar
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sent #5465 to fix screenshot tests |
All 305 screenshot tests passed for commit 8bc457e vs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project import generated by Copybara.