Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move tests from Travis to GitHub Actions #5447

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

abhiomkar
Copy link
Collaborator

Copybara macro requires all tests to run on GitHub Actions.

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #5447 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5447      +/-   ##
==========================================
+ Coverage   97.08%   97.33%   +0.24%     
==========================================
  Files         164      164              
  Lines        6254     6257       +3     
  Branches      823      825       +2     
==========================================
+ Hits         6072     6090      +18     
+ Misses        182      167      -15
Impacted Files Coverage Δ
packages/mdc-notched-outline/component.ts 60.71% <0%> (-17.86%) ⬇️
packages/mdc-auto-init/index.ts 92% <0%> (-4%) ⬇️
packages/mdc-icon-button/foundation.ts 100% <0%> (ø) ⬆️
packages/mdc-icon-button/component.ts 100% <0%> (+61.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f8724...76dc9cb. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 545 screenshot tests passed for commit 9f61aad vs. master! 💯🎉

@abhiomkar abhiomkar force-pushed the chore/actions_everywhere branch 2 times, most recently from 8530e0c to 3d26419 Compare January 10, 2020 01:21
@mdc-web-bot
Copy link
Collaborator

All 545 screenshot tests passed for commit 8530e0c vs. master! 💯🎉

@abhiomkar abhiomkar force-pushed the chore/actions_everywhere branch from 3d26419 to 269a284 Compare January 10, 2020 01:23
@mdc-web-bot
Copy link
Collaborator

All 545 screenshot tests passed for commit 3d26419 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 545 screenshot tests passed for commit 269a284 vs. master! 💯🎉

@abhiomkar abhiomkar force-pushed the chore/actions_everywhere branch 10 times, most recently from 39d5ae7 to 15e0032 Compare January 10, 2020 17:38
@mdc-web-bot
Copy link
Collaborator

All 338 screenshot tests passed for commit 39d5ae7 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 338 screenshot tests passed for commit 15e0032 vs. master! 💯🎉

@abhiomkar abhiomkar force-pushed the chore/actions_everywhere branch 2 times, most recently from 3a04dcb to e85ae98 Compare January 10, 2020 18:10
@@ -109,7 +109,7 @@
"karma-firefox-launcher": "^1.0.0",
"karma-jasmine": "^2.0.1",
"karma-mocha": "^1.3.0",
"karma-sauce-launcher": "^1.0.0",
"karma-sauce-launcher": "^2.0.2",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgraded this to v2 to make Sauce run on IE 11.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting following error with karma-sauce-launcher@v1:

10 01 2020 17:03:34.929:ERROR [launcher.sauce]: Can not start internet explorer 11 (Windows 10)
  [init({"version":"11","platform":"Windows 10","tags":[],"name":"Material Components Web Unit Tests - CI","tunnel-identifier":"mdc-tests-pull_request-run2-aa8af193df8f090be90ba0e949e60710e4d3d160-tunnel","record-video":false,"record-screenshots":false,"device-orientation":null,"disable-popup-handler":true,"build":"mdc-tests-pull_request-run2-aa8af193df8f090be90ba0e949e60710e4d3d160","public":null,"customData":{},"base":"SauceLabs","browserName":"internet explorer"})] The environment you requested was unavailable.

@abhiomkar abhiomkar force-pushed the chore/actions_everywhere branch from e85ae98 to 0267f11 Compare January 10, 2020 18:33
@@ -126,6 +126,7 @@
"protobufjs": "~6.8.6",
"ps-node": "^0.1.6",
"recast": "^0.17.3",
"request": "^2.88.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading karma-sauce-launcher removed request module which is required by "request-promise-native". So I had to re-install this again.

@abhiomkar abhiomkar force-pushed the chore/actions_everywhere branch from 0267f11 to 76dc9cb Compare January 10, 2020 18:42
@mdc-web-bot
Copy link
Collaborator

All 320 screenshot tests passed for commit 76dc9cb vs. master! 💯🎉

@abhiomkar abhiomkar merged commit 910c375 into master Jan 10, 2020
@abhiomkar abhiomkar deleted the chore/actions_everywhere branch January 10, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants