Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

feat(textfield): add end-alignment #5356

Merged
merged 8 commits into from
Jan 6, 2020
Merged

Conversation

asyncLiz
Copy link
Contributor

No description provided.

@asyncLiz asyncLiz self-assigned this Dec 18, 2019
@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #5356 into master will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5356      +/-   ##
=========================================
+ Coverage   98.28%   98.3%   +0.02%     
=========================================
  Files         163     163              
  Lines        6287    6315      +28     
  Branches      851     865      +14     
=========================================
+ Hits         6179    6208      +29     
+ Misses        108     107       -1
Impacted Files Coverage Δ
packages/mdc-textfield/constants.ts 100% <ø> (ø) ⬆️
packages/mdc-textfield/component.ts 98.59% <83.33%> (-0.45%) ⬇️
packages/mdc-radio/foundation.ts 81.81% <0%> (-18.19%) ⬇️
packages/mdc-radio/component.ts 87.5% <0%> (-8.16%) ⬇️
packages/mdc-switch/component.ts 91.37% <0%> (-6.9%) ⬇️
packages/mdc-base/component.ts 93.33% <0%> (-6.67%) ⬇️
packages/mdc-auto-init/index.ts 92% <0%> (-4%) ⬇️
packages/mdc-tab/component.ts 95.08% <0%> (-3.23%) ⬇️
packages/mdc-ripple/component.ts 98.11% <0%> (-1.89%) ⬇️
packages/mdc-chips/chip-set/component.ts 97.4% <0%> (-1.25%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d42ee6...578401b. Read the comment docs.

packages/mdc-textfield/component.ts Outdated Show resolved Hide resolved
packages/mdc-textfield/README.md Outdated Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

@mdc-web-bot
Copy link
Collaborator

Copy link
Contributor

@patrickrodee patrickrodee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's get test passing then I'll stamp. The failing test is unrelated to this so we can probably just exclude it (it's been horribly flaky lately). We can configure Firefox to skip the test here.

@patrickrodee
Copy link
Contributor

Looks like some flaky menu screenshots already got fixed. Might be able to revert the diffing.json updates by resolving merge conflicts.

@mdc-web-bot
Copy link
Collaborator

Copy link
Contributor

@patrickrodee patrickrodee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asyncLiz asyncLiz force-pushed the feat/textfield/end-align branch from 3c3d7b6 to 578401b Compare January 3, 2020 22:39
@mdc-web-bot
Copy link
Collaborator

@asyncLiz asyncLiz merged commit 847dd1a into master Jan 6, 2020
@asyncLiz asyncLiz deleted the feat/textfield/end-align branch January 6, 2020 18:08
@github-actions github-actions bot mentioned this pull request Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants