-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5356 +/- ##
=========================================
+ Coverage 98.28% 98.3% +0.02%
=========================================
Files 163 163
Lines 6287 6315 +28
Branches 851 865 +14
=========================================
+ Hits 6179 6208 +29
+ Misses 108 107 -1
Continue to review full report at Codecov.
|
🤖 Beep boop! Screenshot test report 🚦3 screenshots changed from Details |
test/screenshot/spec/mdc-textfield/classes/baseline-end-aligned.html
Outdated
Show resolved
Hide resolved
🤖 Beep boop! Screenshot test report 🚦6 screenshots changed from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's get test passing then I'll stamp. The failing test is unrelated to this so we can probably just exclude it (it's been horribly flaky lately). We can configure Firefox to skip the test here.
Looks like some flaky menu screenshots already got fixed. Might be able to revert the diffing.json updates by resolving merge conflicts. |
🤖 Beep boop! Screenshot test report 🚦6 screenshots changed from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3c3d7b6
to
578401b
Compare
🤖 Beep boop! Screenshot test report 🚦6 screenshots changed from |
No description provided.