Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): Remove edge detection for CSS custom properties #5264

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

abhiomkar
Copy link
Collaborator

BREAKING CHANGE: Removed $edgeOptOut option from mdc-theme-prop() Sass mixin.

This is no longer requires since the references bug seems to be fixed. See https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/11495448/

cl/281379665

@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit cf3e164 vs. master! 💯🎉

@abhiomkar abhiomkar force-pushed the fix/remove_edge_detect branch from cf3e164 to 01d387f Compare November 20, 2019 22:09
@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 01d387f vs. master! 💯🎉

@abhiomkar abhiomkar force-pushed the fix/remove_edge_detect branch from 01d387f to cbf5837 Compare November 22, 2019 16:33
@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #5264 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5264      +/-   ##
==========================================
- Coverage   98.63%   98.63%   -0.01%     
==========================================
  Files         122      122              
  Lines        6002     5991      -11     
  Branches      772      770       -2     
==========================================
- Hits         5920     5909      -11     
  Misses         81       81              
  Partials        1        1
Impacted Files Coverage Δ
packages/mdc-ripple/util.ts 90% <100%> (-2.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ecc29...264b0a7. Read the comment docs.

@abhiomkar abhiomkar force-pushed the fix/remove_edge_detect branch from cbf5837 to 264b0a7 Compare November 22, 2019 18:34
@mdc-web-bot
Copy link
Collaborator

All 731 screenshot tests passed for commit 264b0a7 vs. master! 💯🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants