Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radio): Add disabled state color mixins #5168

Merged
merged 7 commits into from
Oct 29, 2019

Conversation

allan-chen
Copy link
Collaborator

@allan-chen allan-chen commented Oct 10, 2019

Adds the mdc-radio-disabled-unchecked-stroke-color, mdc-radio-disabled-checked-stroke-color, and the mdc-disabled-radio-ink-color mix-ins for radio buttons in disabled state.

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from develop on commit bde69f8:

Details

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from develop on commit b10d74d:

Details

@allan-chen allan-chen requested a review from abhiomkar October 11, 2019 17:21
@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from develop on commit 90a6f26:

Details

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from develop on commit f9b11c2:

Details

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from develop on commit 71440cf:

Details

packages/mdc-radio/_mixins.scss Outdated Show resolved Hide resolved
packages/mdc-radio/_mixins.scss Show resolved Hide resolved
test/screenshot/golden.json Show resolved Hide resolved
packages/mdc-radio/_mixins.scss Outdated Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge this at the time of CL submit.

@allan-chen allan-chen merged commit b5c6d66 into develop Oct 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/radio-disabled-colors branch October 29, 2019 17:51
@jamesmfriedman jamesmfriedman mentioned this pull request Nov 4, 2019
93 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants