Skip to content

Commit

Permalink
Move aria attrs from container to surface.
Browse files Browse the repository at this point in the history
  • Loading branch information
joyzhong committed Nov 7, 2019
1 parent 2fc3d44 commit 008c36d
Show file tree
Hide file tree
Showing 10 changed files with 60 additions and 60 deletions.
12 changes: 6 additions & 6 deletions packages/mdc-dialog/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ npm install @material/dialog

```html
<div class="mdc-dialog">
<div class="mdc-dialog__container"
<div class="mdc-dialog__container">
<div class="mdc-dialog__surface"
role="alertdialog"
aria-modal="true"
aria-labelledby="my-dialog-title"
aria-describedby="my-dialog-content">
<div class="mdc-dialog__surface">
<!-- Title cannot contain leading whitespace due to mdc-typography-baseline-top() -->
<h2 class="mdc-dialog__title" id="my-dialog-title"><!--
-->Dialog Title<!--
Expand Down Expand Up @@ -115,12 +115,12 @@ The Simple Dialog contains a list of potential actions. It does not contain butt

```html
<div class="mdc-dialog">
<div class="mdc-dialog__container"
<div class="mdc-dialog__container">
<div class="mdc-dialog__surface"
role="alertdialog"
aria-modal="true"
aria-labelledby="my-dialog-title"
aria-describedby="my-dialog-content">
<div class="mdc-dialog__surface">
<!-- Title cannot contain leading whitespace due to mdc-typography-baseline-top() -->
<h2 class="mdc-dialog__title" id="my-dialog-title"><!--
-->Choose a Ringtone<!--
Expand Down Expand Up @@ -151,12 +151,12 @@ radio buttons (indicating single selection) or checkboxes (indicating multiple s

```html
<div class="mdc-dialog">
<div class="mdc-dialog__container"
<div class="mdc-dialog__container">
<div class="mdc-dialog__surface"
role="alertdialog"
aria-modal="true"
aria-labelledby="my-dialog-title"
aria-describedby="my-dialog-content">
<div class="mdc-dialog__surface">
<!-- Title cannot contain leading whitespace due to mdc-typography-baseline-top() -->
<h2 class="mdc-dialog__title" id="my-dialog-title"><!--
-->Choose a Ringtone<!--
Expand Down
12 changes: 6 additions & 6 deletions test/screenshot/spec/mdc-dialog/mixins/container-fill-color.html
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@
<div class="mdc-dialog mdc-dialog--open test-dialog test-dialog--container-fill-color"
id="test-dialog">
<div class="mdc-dialog__scrim"></div>
<div class="mdc-dialog__container"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<div class="mdc-dialog__surface">
<div class="mdc-dialog__container">
<div class="mdc-dialog__surface"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<h2 class="mdc-dialog__title test-dialog__title test-dialog__title--3-line" id="test-dialog__title"><!--
-->“The Count of Monte Cristo” by Alexandre <span class="test-font--redact-all">Dumas</span>.<br>
Published in 1844 and translated by Robin Buss.<br>
Expand Down
12 changes: 6 additions & 6 deletions test/screenshot/spec/mdc-dialog/mixins/content-ink-color.html
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@
<div class="mdc-dialog mdc-dialog--open test-dialog test-dialog--content-ink-color"
id="test-dialog">
<div class="mdc-dialog__scrim"></div>
<div class="mdc-dialog__container"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<div class="mdc-dialog__surface">
<div class="mdc-dialog__container">
<div class="mdc-dialog__surface"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<h2 class="mdc-dialog__title test-dialog__title test-dialog__title--3-line" id="test-dialog__title"><!--
-->“The Count of Monte Cristo” by Alexandre <span class="test-font--redact-all">Dumas</span>.<br>
Published in 1844 and translated by Robin Buss.<br>
Expand Down
12 changes: 6 additions & 6 deletions test/screenshot/spec/mdc-dialog/mixins/max-height.html
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@
<div class="mdc-dialog mdc-dialog--open test-dialog test-dialog--max-height"
id="test-dialog">
<div class="mdc-dialog__scrim"></div>
<div class="mdc-dialog__container"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<div class="mdc-dialog__surface">
<div class="mdc-dialog__container">
<div class="mdc-dialog__surface"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<h2 class="mdc-dialog__title test-dialog__title test-dialog__title--3-line" id="test-dialog__title"><!--
-->“The Count of Monte Cristo” by Alexandre <span class="test-font--redact-all">Dumas</span>.<br>
Published in 1844 and translated by Robin Buss.<br>
Expand Down
12 changes: 6 additions & 6 deletions test/screenshot/spec/mdc-dialog/mixins/max-width.html
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@
<div class="mdc-dialog mdc-dialog--open test-dialog test-dialog--max-width"
id="test-dialog">
<div class="mdc-dialog__scrim"></div>
<div class="mdc-dialog__container"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<div class="mdc-dialog__surface">
<div class="mdc-dialog__container">
<div class="mdc-dialog__surface"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<h2 class="mdc-dialog__title test-dialog__title test-dialog__title--5-line" id="test-dialog__title"><!--
-->“The Count of Monte Cristo” by Alexandre <span class="test-font--redact-all">Dumas</span>.<br>
Published in 1844 and translated by Robin Buss.<br>
Expand Down
12 changes: 6 additions & 6 deletions test/screenshot/spec/mdc-dialog/mixins/min-width.html
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@
<div class="mdc-dialog mdc-dialog--open test-dialog test-dialog--min-width"
id="test-dialog">
<div class="mdc-dialog__scrim"></div>
<div class="mdc-dialog__container"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<div class="mdc-dialog__surface">
<div class="mdc-dialog__container">
<div class="mdc-dialog__surface"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<h2 class="mdc-dialog__title test-dialog__title" id="test-dialog__title">Title</h2>
<div class="mdc-dialog__content test-dialog__content" id="test-dialog__content">
<div class="test-dialog__content-rect">
Expand Down
12 changes: 6 additions & 6 deletions test/screenshot/spec/mdc-dialog/mixins/scrim-color.html
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@
<div class="mdc-dialog mdc-dialog--open test-dialog test-dialog--scrim-color"
id="test-dialog">
<div class="mdc-dialog__scrim"></div>
<div class="mdc-dialog__container"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<div class="mdc-dialog__surface">
<div class="mdc-dialog__container">
<div class="mdc-dialog__surface"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<h2 class="mdc-dialog__title test-dialog__title test-dialog__title--3-line" id="test-dialog__title"><!--
-->“The Count of Monte Cristo” by Alexandre <span class="test-font--redact-all">Dumas</span>.<br>
Published in 1844 and translated by Robin Buss.<br>
Expand Down
12 changes: 6 additions & 6 deletions test/screenshot/spec/mdc-dialog/mixins/scroll-divider-color.html
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@
<div class="mdc-dialog mdc-dialog--open test-dialog test-dialog--scroll-divider-color"
id="test-dialog">
<div class="mdc-dialog__scrim"></div>
<div class="mdc-dialog__container"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<div class="mdc-dialog__surface">
<div class="mdc-dialog__container">
<div class="mdc-dialog__surface"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<h2 class="mdc-dialog__title test-dialog__title test-dialog__title--3-line" id="test-dialog__title"><!--
-->“The Count of Monte Cristo” by Alexandre <span class="test-font--redact-all">Dumas</span>.<br>
Published in 1844 and translated by Robin Buss.<br>
Expand Down
12 changes: 6 additions & 6 deletions test/screenshot/spec/mdc-dialog/mixins/shape-radius.html
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@
<div class="mdc-dialog mdc-dialog--open test-dialog test-dialog--shape-radius"
id="test-dialog">
<div class="mdc-dialog__scrim"></div>
<div class="mdc-dialog__container"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<div class="mdc-dialog__surface">
<div class="mdc-dialog__container">
<div class="mdc-dialog__surface"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<h2 class="mdc-dialog__title test-dialog__title test-dialog__title--3-line" id="test-dialog__title"><!--
-->“The Count of Monte Cristo” by Alexandre <span class="test-font--redact-all">Dumas</span>.<br>
Published in 1844 and translated by Robin Buss.<br>
Expand Down
12 changes: 6 additions & 6 deletions test/screenshot/spec/mdc-dialog/mixins/title-ink-color.html
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@
<div class="mdc-dialog mdc-dialog--open test-dialog test-dialog--title-ink-color"
id="test-dialog">
<div class="mdc-dialog__scrim"></div>
<div class="mdc-dialog__container"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<div class="mdc-dialog__surface">
<div class="mdc-dialog__container">
<div class="mdc-dialog__surface"
role="alertdialog"
aria-modal="true"
aria-labelledby="test-dialog__title"
aria-describedby="test-dialog__content">
<h2 class="mdc-dialog__title test-dialog__title test-dialog__title--3-line" id="test-dialog__title"><!--
-->“The Count of Monte Cristo” by Alexandre <span class="test-font--redact-all">Dumas</span>.<br>
Published in 1844 and translated by Robin Buss.<br>
Expand Down

0 comments on commit 008c36d

Please sign in to comment.