fix(popper): adding missing memoisation

mateoguzmana · Dec 10, 2022 · ea500e9 · ea500e9
1 parent 9dc7d6c
commit ea500e9
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/src/components/Popper.tsx b/src/components/Popper.tsx
@@ -79,11 +79,18 @@ export const Popper = memo(
         [direction]
       );
 
-      const optimalNumberOfItems = Math.floor(screenWidth / spacing);
-      const itemsToRenderArray = [...Array(optimalNumberOfItems)];
+      const optimalNumberOfItems = useMemo(
+        () => Math.floor(screenWidth / spacing),
+        [spacing]
+      );
+      const itemsToRenderArray = useMemo(
+        () => [...Array(optimalNumberOfItems)],
+        [optimalNumberOfItems]
+      );
 
-      const yPositions = shuffleArray(
-        itemsToRenderArray.map((_, i) => i * spacing)
+      const yPositions = useMemo(
+        () => shuffleArray(itemsToRenderArray.map((_, i) => i * spacing)),
+        [itemsToRenderArray, spacing]
       );
 
       const containerYPosition = useValue(initialPosition);