fix(firework): removing unnecessary autoplay prop

mateoguzmana · Aug 14, 2022 · 3ebc760 · 3ebc760
1 parent c87e728
commit 3ebc760
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/example/src/App.tsx b/example/src/App.tsx
@@ -83,7 +83,6 @@ function App() {
           <Canvas style={styles.canvas}>
             <Firework
               color="blue"
-              autoplay={false}
               particlesInitialPosition={{ x: 0, y: 50 }}
               particlesFinalposition={{
                 xValues: fireworksPositions?.xValues ?? [],

diff --git a/src/components/Firework.tsx b/src/components/Firework.tsx
@@ -24,14 +24,12 @@ interface FireworkProps {
   particlesFinalposition?: FireworkParticlePositions;
   particlesInitialPosition?: FireworkPosition;
   color: string;
-  autoplay?: boolean;
 }
 
 function Firework({
   particlesFinalposition,
   color,
   particlesInitialPosition,
-  autoplay,
 }: FireworkProps) {
   return (
     <>
@@ -46,7 +44,6 @@ function Firework({
           }}
           r={8}
           color={color ?? '#000'}
-          autoplay={autoplay}
         />
       ))}
     </>

diff --git a/src/components/FireworkParticle.tsx b/src/components/FireworkParticle.tsx
@@ -18,7 +18,6 @@ interface FireworkParticleProps {
   };
   r: number;
   color: string;
-  autoplay?: boolean;
 }
 
 function FireworkParticle({
@@ -27,7 +26,6 @@ function FireworkParticle({
   finalPos,
   r,
   color,
-  autoplay,
 }: FireworkParticleProps) {
   const xPosition = useValue(x);
   const yPosition = useValue(y);
@@ -74,8 +72,8 @@ function FireworkParticle({
   }, [changeOpacity, changeXPosition, changeYPosition]);
 
   useEffect(() => {
-    true && pushBalloons();
-  }, [autoplay, pushBalloons]);
+    pushBalloons();
+  }, [pushBalloons]);
 
   return (
     <Group transform={transform}>