-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support change password with passwdqc #762
base: master
Are you sure you want to change the base?
Conversation
This one was quite tricky ... On systems where pam_passwdqc is installed the prompt for password after succesfully authenticating is not: ``` New password: ``` But: ``` Enter new password: ``` See: https://github.com/openwall/passwdqc/blob/7bf266fcf6ce9782b73722664e36dabd68f48c48/pam_passwdqc.c#L64 passwdqc is installed by default in Gentoo, but might be also installed in other Linux distributions.
I don't have libpam-passwdqc installed on my system so of course I've never seen this, but it seems to me if you are checking the strength of a password or changing a password, "Enter new password:" and "new password:" are functionally equivalent. This is not something I know much about, so I will have to leave this for others to review for now |
Same, but the changes look reasonable (not tested though). |
In master I was able to fix the travis issue in Debian, which was caused by a no longer offered transitional package. This time around though we got a "failure to deploy" error in Fedora, though as the ci fix was not a release that code should not have run at all. Was NOT the gem error I was getting elsewhere, but is beyond my knowledge or ability to fix unaided
|
This one was quite tricky ... On systems where pam_passwdqc is installed the prompt for password after succesfully authenticating is not:
But:
See:
https://github.com/openwall/passwdqc/blob/7bf266fcf6ce9782b73722664e36dabd68f48c48/pam_passwdqc.c#L64
passwdqc is installed by default in Gentoo, but might be also installed in other Linux distributions.