-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mouse: feature pointer size control #698
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want this? If you can control the size of the pointer there, why not the aspect/theme?
IMO if anything there should be a button opening the pointer theme options which include both, or redesign things to have everything in one place (a third tab with the theme, if really we want it there? but then there is the same problem in the theme dialog which would have to link here).
Also, I don't like the idea there are two sliders that control the same thing: it looks like you could control the size of the mouse and touchpad pointers separately with this, but it's not the case (and is not really a thing anyway).
Finally, this duplicates all the details of the slider (I didn't check if they were consistent), especially min/max values, which can be annoying to maintain and keep in sync everywhere.
From an UI designer point of view, you're right.
This could be a possibility but I don't want to make a revolution! Some people already did and that led to the Mate fork!
I just mimicked what is done for the "Pointer Speed" option, that already duplicates controls.
Min/max/step values are taken from a GtkAdjustment that is shared between both scales. |
a04f091
to
bd22a1c
Compare
can't you already configure pointer size in AppearancePreferences->Theme->Customise->Pointer->Size ? |
Yes, you can. If you're seeking for complex ways to do it, you can also use dconf-editor :-) |
what about a button/link "Go to cursor appearance preferences" that would pop up the appearance prefs dialog at the right tab? |
Could be an alternate approach if the proper page can be accessed. In addition, |
That could probably be augmented to include the missing bits, it's not really a problem if it needs to pop another dialog on top of it, it's quite easy to do it. But it has to be done indeed, it's not already there. |
I don't think it would keep it simple, although logic from a UI designer standpoint:
|
code comments where handled, and the rest is discussion and opinion, not worth a blocker
What is the status of this? |
This adds a mouse/touchpad pointer size control scale to both pages of the mouse properties dialog.